Merge lp:~manu-tiedra/openobject-addons/pexego_extra_6.0 into lp:~pexego/openobject-addons/extra-6.0

[Manu]

[FIX] fixed bug creating the lot sequence. name was False in the method create (in product_lot_sequence/product.py)

There was an error creating a sequence in the create method of product_lot_sequence/product.py

product.name was False. I'm using vals["name"] instead. For the explanation I've copied this from product_variant_multi:

    def create(self, cr, uid, vals, context=None):
        #TAKE CARE for inherits objects openerp will create firstly the product_template and after the product_product
        # and so the duplicated fields (duplicated field = field which are on the template and on the variant) will be on the product_template and not on the product_product
        #Also when a product is created the duplicated field are empty for the product.product, this is why the field name can not be a required field
        #This should be fix in the orm in the futur
        ids = super(product_product, self).create(cr, uid, vals.copy(), context=context) #using vals.copy() if not the vals will be changed by calling the super method
        ####### write the value in the product_product

[lp:~manu-tiedra/openobject-addons/pexego_extra_6.0]

18. By Manu on 2011-12-29

[FIX]/[IMP] fixed bug creating the lot sequence. name was False in the method create (in product_lot_sequence/product.py). Also a new lot sequence number is created only if the product will be manufactured to avoid cluttering of sequences

[Omar (Pexego) (omar7r)]

review: Approve

=== modified file 'product_lot_sequence/product.py'
--- product_lot_sequence/product.py	2011-12-26 12:47:25 +0000
+++ product_lot_sequence/product.py	2011-12-29 18:08:24 +0000
@@ -40,15 +40,19 @@
                  }
 
     def create(self, cr, uid, vals, context={}):
-        """overwrites create method to create new sequence to production lots"""
+        """overwrites create method to create new sequence for production lots"""
         product_id = super(product_product, self).create(cr, uid, vals, context=context)
         product = self.browse(cr, uid, product_id)
-        #Manages the sequence number
+
+        #Manages a custom sequence number only if the product will be manufactured
+        if not(product.supply_method == 'produce' and product.type != 'service'):
+            return product_id
+
         if not vals.get('sequence_id'):
-            sequence_id = get_default_seq_id(cr, uid, product.default_code, product.name, company_id=product.company_id and product.company_id.id or False)
+            sequence_id = get_default_seq_id(cr, uid, product.default_code, product.name_template, company_id=product.company_id and product.company_id.id or False)
             if sequence_id:
                 self.write(cr, uid, [product_id], {'sequence_id': sequence_id})
 
         return product_id
 
-product_product()
 \ No newline at end of file
+product_product()