Merge lp:~mank319/pantheon-files/navigation-buttons into lp:~elementary-apps/pantheon-files/trunk

Proposed by Manuel Kehl on 2014-10-28
Status: Merged
Approved by: Daniel Fore on 2014-11-08
Approved revision: 1630
Merged at revision: 1635
Proposed branch: lp:~mank319/pantheon-files/navigation-buttons
Merge into: lp:~elementary-apps/pantheon-files/trunk
Diff against target: 29 lines (+12/-0)
1 file modified
src/View/Window.vala (+12/-0)
To merge this branch: bzr merge lp:~mank319/pantheon-files/navigation-buttons
Reviewer Review Type Date Requested Status
Jeremy Wootten 2014-10-28 Approve on 2014-11-02
Review via email: mp+239882@code.launchpad.net

Commit message

XF86Back and XF86Forward can now be used to navigate back and forth in pantheon-files, which probably is what most users with such buttons would expect.

Description of the change

XF86Back and XF86Forward can now be used to navigate back and forth in pantheon-files, which probably is what most users with such buttons would expect.

I adapted the mechanism of "go_up" to make sure that I meet the expectations of your code base. I hope the changes are useful and would love to see them merged!

Please tell me if there is anything about my contribution, that you would like me to change, because both Vala and Launchpad/Bazaar are completely new to me ;-)

To post a comment you must log in.
1630. By Manuel Kehl on 2014-11-02

Bound the signals to the corresponding keys (XF86Back, XF86Forward).

Jeremy Wootten (jeremywootten) wrote :

The branch works as expected and the code is clean.

Thanks for your contribution Manuel!

review: Approve
Manuel Kehl (mank319) wrote :

Thank you for the review!

On So, Nov 2, 2014 at 12:05 , Jeremy Wootten <email address hidden>
wrote:
> Review: Approve
>
> The branch works as expected and the code is clean.
>
> Thanks for your contribution Manuel!
> --
> https://code.launchpad.net/~mank319/pantheon-files/navigation-buttons/+merge/239882
> You are the owner of lp:~mank319/pantheon-files/navigation-buttons.

Jeremy Wootten (jeremywootten) wrote :

No problem, I hope you are able to contribute again in the future - there
is plenty more work to do on Files!

On 2 November 2014 11:48, Manuel Kehl <email address hidden> wrote:

> Thank you for the review!
>
> On So, Nov 2, 2014 at 12:05 , Jeremy Wootten <email address hidden>
> wrote:
> > Review: Approve
> >
> > The branch works as expected and the code is clean.
> >
> > Thanks for your contribution Manuel!
> > --
> >
> https://code.launchpad.net/~mank319/pantheon-files/navigation-buttons/+merge/239882
> > You are the owner of lp:~mank319/pantheon-files/navigation-buttons.
>
> --
>
> https://code.launchpad.net/~mank319/pantheon-files/navigation-buttons/+merge/239882
> You are reviewing the proposed merge of
> lp:~mank319/pantheon-files/navigation-buttons into lp:pantheon-files.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/View/Window.vala'
2--- src/View/Window.vala 2014-10-15 12:26:22 +0000
3+++ src/View/Window.vala 2014-11-02 10:09:28 +0000
4@@ -285,6 +285,8 @@
5 if (is_first_window) {
6 unowned Gtk.BindingSet binding_set = Gtk.BindingSet.by_class (get_class ());
7 Gtk.BindingEntry.add_signal (binding_set, Gdk.keyval_from_name ("BackSpace"), 0, "go_up", 0);
8+ Gtk.BindingEntry.add_signal (binding_set, Gdk.keyval_from_name ("XF86Back"), 0, "go_back", 0);
9+ Gtk.BindingEntry.add_signal (binding_set, Gdk.keyval_from_name ("XF86Forward"), 0, "go_forward", 0);
10 Gtk.BindingEntry.add_signal (binding_set, Gdk.keyval_from_name ("L"), Gdk.ModifierType.CONTROL_MASK, "edit_path", 0);
11 }
12
13@@ -306,6 +308,16 @@
14 public virtual signal void go_up () {
15 action_go_up ();
16 }
17+
18+ [Signal (action=true)]
19+ public virtual signal void go_back () {
20+ action_go_back ();
21+ }
22+
23+ [Signal (action=true)]
24+ public virtual signal void go_forward () {
25+ action_go_forward ();
26+ }
27
28 [Signal (action=true)]
29 public virtual signal void edit_path () {

Subscribers

People subscribed via source and target branches

to all changes: