Merge lp:~manishsinha/zeitgeist/new-blacklist-implementation into lp:zeitgeist/0.1
Proposed by
Manish Sinha (मनीष सिन्हा)
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 1711 | ||||
Proposed branch: | lp:~manishsinha/zeitgeist/new-blacklist-implementation | ||||
Merge into: | lp:zeitgeist/0.1 | ||||
Diff against target: |
251 lines (+103/-43) 2 files modified
_zeitgeist/engine/extensions/blacklist.py (+86/-27) test/blacklist-test.py (+17/-16) |
||||
To merge this branch: | bzr merge lp:~manishsinha/zeitgeist/new-blacklist-implementation | ||||
Related bugs: |
|
||||
Related blueprints: |
Revamp the blacklist API
(High)
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Markus Korn | Approve | ||
Mikkel Kamstrup Erlandsen | Approve | ||
Review via email:
|
Description of the change
Implements the new Blacklist API as per http://
* All methods implemented
* Add signals implemented
* Unit Tests updated accordingly
To post a comment you must log in.
35 + PUBLIC_METHODS = ["add_blacklist", "get_blacklist"]
Maybe add remove_blacklist here as well?
75 + def add_blacklist(self, event_id, event_template): blacklist( self, event_id):
85 + def remove_
104 + def AddTemplate(self, event_id, event_template):
Should the first arg not be named blacklist_id or?
143 + def RemoveTemplates (self, event_id):
Again, arg should be blacklist_id? Also is it not RemoveTemplate (ie. not plural)