Code review comment for lp:~manishsinha/zeitgeist/fix-blacklist-api

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

> line 15-19 in the patch is unnecessary it can be replaced at line 15 with
> ---
> self._blacklist = pickle.load(file(CONFIG_FILE))
> ---

Will check when I reach home

> line 52 in the patch can be removed and is not needed, since internally we do
> not need to make event dbus send-able unless we are sending them out.

Agree

> line 82 in the patch can be removed and is not needed, since internally we do
> not need to make event dbus send-able unless we are sending them out.

Agree

« Back to merge proposal