Code review comment for lp:~manishsinha/zeitgeist/fix-blacklist-api

Revision history for this message
Markus Korn (thekorn) wrote :

> It is a good momentum generator now so lets keep on this.

I hate your momentum generators, they make me thinking about problems like this in an endless loop ;)

Can someone please summarize for me why we want this string identifier 'blacklister' for the client setting a certain blacklist? And why is it not an identifier for the blacklist template itself?
In my understanding it's purely informational, so why do we group the templates internally by this string, instead we could just maintain templates internally as
   blacklists = set([(<template1>, "client1"), (<template2>, "client1"), (<template3>, "client2")])

« Back to merge proposal