Code review comment for lp:~manishsinha/zeitgeist/fix-blacklist-api
Revision history for this message
| Siegfried Gevatter (rainct) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
A quick comment: How's the Changed signal supposed to work, ie. how do you know if the templates are being added or removed? Why not have two separated signals (TemplatesAdded, TemplatesRemoved)?
I also don't buy this "blacklister" stuff. What's the point of it?