Code review comment for lp:~manishsinha/zeitgeist-datasources/bzr-improvements-subjects

Am 24/03/12 23:14, schrieb Michal Hruby:
>> The action is triggered by the user though, it's not an external action. If
>> the user downloads a file from elsewhere onto the local system, then isn't
>> that still USER_ACTIVTITY, even if the user didn't write the (entire) file?
>>
> That's questionable, I can have a cron job that calls bzr pull in multiple directories. As for downloading something - of course you don't need to write the file yourself for it to be considered a user activity, but in case of a download the user does in fact request that specific file, unlike bzr where you're actually saying update this repository, you don't care about the individual files.
What if it's e.g. unpacking a zip file?

Anyway, I think this all depends on the zeitgeist data model and what
you want to do with it.

> That's why I also don't really like this approach, you're increasing global relevancy of subjects you could have actually never worked with. (consider kernel-like bzr tree and the thousands of files when you do a single pull).
Note that it was seif who proposed that. I think just using the branch
as subject is fine, and that's why my original branch did.

Cheers,

Jelmer