Code review comment for lp:~manishsinha/zeitgeist-datasources/bzr-improvements-subjects
Revision history for this message
| Michal Hruby (mhr3) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> The action is triggered by the user though, it's not an external action. If
> the user downloads a file from elsewhere onto the local system, then isn't
> that still USER_ACTIVTITY, even if the user didn't write the (entire) file?
>
That's questionable, I can have a cron job that calls bzr pull in multiple directories. As for downloading something - of course you don't need to write the file yourself for it to be considered a user activity, but in case of a download the user does in fact request that specific file, unlike bzr where you're actually saying update this repository, you don't care about the individual files.
That's why I also don't really like this approach, you're increasing global relevancy of subjects you could have actually never worked with. (consider kernel-like bzr tree and the thousands of files when you do a single pull).