Code review comment for lp:~manishsinha/zeitgeist-datasources/bzr-improvements-subjects

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

> The other subjects shouldn't be set if there is no working tree (in that case the files don't exist on disk).

Can you give some examples?

> I think the other subjects should only be set in the case of push and pull, and not in the case of commit as commit doesn't actually change those files.

The think the reverse. In a commit there are various files involved. A file can be added/deleted/modified which form a part of an commit (which is an event)

In case of push and pull, we get the remote URI like bzr+shh:// which is not a valid URI for Gio.File due to which mimetype cannot be fetched.

> It would make sense to add a post_merge hook too

It would be good, but right now my plan was to get these three events and try to write a small client trying to understand how the information can be used. I have already trimmed XChat dataprovider as it was logging too much and was spamming the database with useless events. Before going ahead and adding merge/revert hooks, it would nice to know how we can use those events.

« Back to merge proposal