Code review comment for lp:~manishsinha/zeitgeist-datasources/bzr-improvements-subjects
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> You're using USER_ACTIVITY in all cases, but if I just pull, all the changed files definitely aren't changed by the user, so
> that's clearly wrong.
The action is triggered by the user though, it's not an external action. If the user downloads a file from elsewhere onto the local system, then isn't that still USER_ACTIVTITY, even if the user didn't write the (entire) file?
> All in all I'm not really sure what to think of this dataprovider, more data is good (I guess), but whenever you really work
> with any of the files from the repo, you're using an editor. I can't shake off the feeling we're trying to somehow duplicate
> what the VCS system does itself - keep a commit log.
That's true - though it's more like a tiplog. In other words, this records the changes to the tip of this particular branch, rather than the actual history. If the current branch updates from revision 10 to revision 30, then that's a single change here, not 20.