Code review comment for lp:~manishsinha/zeitgeist-datasources/bzr-improvements-subjects
Revision history for this message
| Michal Hruby (mhr3) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
You're using USER_ACTIVITY in all cases, but if I just pull, all the changed files definitely aren't changed by the user, so that's clearly wrong.
+1 on the is_push misusage.
All in all I'm not really sure what to think of this dataprovider, more data is good (I guess), but whenever you really work with any of the files from the repo, you're using an editor. I can't shake off the feeling we're trying to somehow duplicate what the VCS system does itself - keep a commit log.