Code review comment for lp:~manishsinha/cheers/basic-working-filemonitor-and-parse-json-trophies

Hey guys I built on top of this branch into
https://code.launchpad.net/~cheers/cheers/dev
I separated the remote dbus api from the logic to keep things clean.
Please check the commit messages the code looks fine. All we need now is to
extends the remote api like in the old code...
Cheers
Seif

On Fri, Nov 5, 2010 at 8:49 AM, Manish Sinha <email address hidden> wrote:

> Adding to the above comment, doing this way will help every reviewer have a
> grasp on the whole codebase without actually having to look at it when it is
> done. Reviewing big codebase is tough(though cheers codebase wont grow so
> big) and a big code drop is difficult to gulp down.
>
> So what should we have the dbus name and object path as? Originally it is
> org.gnome.cheers (which is somewhat we should not take). AFAIK Zeitgeist had
> org.gnome.zeitgeist due to historical reasons.
> --
>
> https://code.launchpad.net/~manishsinha/cheers/basic-working-filemonitor-and-parse-json-trophies/+merge/40149
> Your team Cheers is requested to review the proposed merge of
> lp:~manishsinha/cheers/basic-working-filemonitor-and-parse-json-trophies
> into lp:cheers.
>

--
This is me doing some advertisement for my blog http://seilo.geekyogre.com