Code review comment for lp:~manishsinha/cheers/basic-working-filemonitor-and-parse-json-trophies

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

Adding to the above comment, doing this way will help every reviewer have a grasp on the whole codebase without actually having to look at it when it is done. Reviewing big codebase is tough(though cheers codebase wont grow so big) and a big code drop is difficult to gulp down.

So what should we have the dbus name and object path as? Originally it is org.gnome.cheers (which is somewhat we should not take). AFAIK Zeitgeist had org.gnome.zeitgeist due to historical reasons.

« Back to merge proposal