Code review comment for lp:~mandel/unity/no-global-search-previews

Revision history for this message
Manuel de la Peña (mandel) wrote :

> No problem, but some a little problem.
>
> The tab spaces for the AP are 4 not 2 ( I should have mentioned that)

All the python code I added is using tabspaces to 4 unless vim is lying (ts=4; expandtab; retab)

>
> The other problem is you have the test under the class DashCrossMonitorsTests,
> which means it will get skipped if the testing machine doesn't have more then
> 1 monitor. (So moving the test under the class
> PreviewInvocationTests(DashTestCase): would fix that problem) :)

I'm stupid, I just appended the test to the last test case.

« Back to merge proposal