Code review comment for lp:~mandel/unity/fix-static-cairo-text

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

Fix works ok and test passes, but since you're there... Could you please get rid of the _labelText variable (you can just use the StaticCairoText::GetText where needed)? It looks like a duplication to me.

150 + Settings* settings;

No need a pointer here... Just add Settings settings;

« Back to merge proposal