Code review comment for lp:~mandel/unity/add-text-entry

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> > In this way there is a lot of code duplication in SearchBar and TextInput.
> In
> > some ways we can avoid this. What do you think?
>
> I'm more than happy to re-factor the code, but is that something that all
> agree with? Bare in mind that there is a number of important differences
> between the two of them:
>
> * timer for the searches
> * spinner
> * search icon (the magnifier)
>
> We can surely make the text entry be flexible enough to be able to be hooked
> with signals that can be used for the searches and the timer. I'm not that
> sure about the changes to be done in the layout to accommodate the spinner and
> the icon.

Ok never mind ;) Will be done later.

« Back to merge proposal