Code review comment for lp:~mandel/unity/add-text-entry

Havent finished looking at it, but here are a few points I have so far.

53 +const int LIVE_SEARCH_TIMEOUT = 40;
55 +const int SPACE_BETWEEN_SPINNER_AND_TEXT = 5;
58 +const int SEARCH_ENTRY_RIGHT_BORDER = 10;

This isn't a search bar, and there is no spinner.

120 +TextInput::TextInput(NUX_FILE_LINE_DECL)
121 + : View(NUX_FILE_LINE_PARAM)
122 + , input_hint("")
123 + , last_width_(-1)
124 + , last_height_(-1)
125 +{
126 + Init();
127 +}
128 +
129 +TextInput::TextInput(bool show_filter_hint_, NUX_FILE_LINE_DECL)
130 + : View(NUX_FILE_LINE_PARAM)
131 + , input_hint("")
132 + , last_width_(-1)
133 + , last_height_(-1)

Not initialising the show_filter_hint_ member

174 + OnFontChanged(gtk_settings_get_default())

If you're not going to have a connection to the gtk font change signal, then it probably shouldn't be called OnFontChanged. Also, why no connection to gtk font update signal?