Merge lp:~mandel/ubuntuone-windows-installer/use_correct_folder_name into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: John Lenton
Approved revision: 176
Merge reported by: Manuel de la Peña
Merged at revision: not available
Proposed branch: lp:~mandel/ubuntuone-windows-installer/use_correct_folder_name
Merge into: lp:ubuntuone-windows-installer/beta
Prerequisite: lp:~mandel/ubuntuone-windows-installer/manual_sync_does_nothing
Diff against target: 304 lines (+210/-8)
6 files modified
src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj (+9/-0)
src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs (+4/-6)
src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs (+1/-1)
src/Canonical.UbuntuOne.Client/Preferences/PreferencesDialogPresenter.cs (+1/-1)
src/Canonical.UbuntuOne.Client/Resources.Designer.cs (+72/-0)
src/Canonical.UbuntuOne.Client/Resources.resx (+123/-0)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/use_correct_folder_name
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+40544@code.launchpad.net

Commit message

Ensures that the default folder name is 'Ubuntu One'

Description of the change

Ensures that the default folder name is 'Ubuntu One'

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) :
review: Approve
177. By Manuel de la Peña

Added resources to point to the correct directory name.

178. By Manuel de la Peña

Updated solution

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj'
--- src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj 2010-11-11 11:46:48 +0000
+++ src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj 2010-11-11 11:46:48 +0000
@@ -95,6 +95,11 @@
95 <Compile Include="Preferences\LoadPreferencesStartupTask.cs" />95 <Compile Include="Preferences\LoadPreferencesStartupTask.cs" />
96 <Compile Include="Preferences\PreferencesDialogPresenter.cs" />96 <Compile Include="Preferences\PreferencesDialogPresenter.cs" />
97 <Compile Include="Properties\AssemblyInfo.cs" />97 <Compile Include="Properties\AssemblyInfo.cs" />
98 <Compile Include="Resources.Designer.cs">
99 <AutoGen>True</AutoGen>
100 <DesignTime>True</DesignTime>
101 <DependentUpon>Resources.resx</DependentUpon>
102 </Compile>
98 <Compile Include="SyncDaemonClient.cs" />103 <Compile Include="SyncDaemonClient.cs" />
99 </ItemGroup>104 </ItemGroup>
100 <ItemGroup>105 <ItemGroup>
@@ -146,6 +151,10 @@
146 <LastGenOutput>NotificationResources.Designer.cs</LastGenOutput>151 <LastGenOutput>NotificationResources.Designer.cs</LastGenOutput>
147 <SubType>Designer</SubType>152 <SubType>Designer</SubType>
148 </EmbeddedResource>153 </EmbeddedResource>
154 <EmbeddedResource Include="Resources.resx">
155 <Generator>ResXFileCodeGenerator</Generator>
156 <LastGenOutput>Resources.Designer.cs</LastGenOutput>
157 </EmbeddedResource>
149 </ItemGroup>158 </ItemGroup>
150 <ItemGroup>159 <ItemGroup>
151 <EmbeddedResource Include="objects.xml" />160 <EmbeddedResource Include="objects.xml" />
152161
=== modified file 'src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs'
--- src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs 2010-10-20 11:18:55 +0000
+++ src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs 2010-11-11 11:46:48 +0000
@@ -18,12 +18,10 @@
18 */18 */
19using System;19using System;
20using System.IO;20using System.IO;
21using System.ServiceModel;
22using Canonical.Ubuntu.SSO;21using Canonical.Ubuntu.SSO;
23using Canonical.UbuntuOne.Client.Preferences;22using Canonical.UbuntuOne.Client.Preferences;
24using Canonical.UbuntuOne.Common;23using Canonical.UbuntuOne.Common;
25using Canonical.UbuntuOne.Common.Aop;24using Canonical.UbuntuOne.Common.Aop;
26using Canonical.UbuntuOne.Common.Net;
27using Canonical.UbuntuOne.Common.Utils;25using Canonical.UbuntuOne.Common.Utils;
28using log4net;26using log4net;
2927
@@ -53,8 +51,8 @@
53 private ISSOCredentialsProvider _ssoProvider;51 private ISSOCredentialsProvider _ssoProvider;
54 private ILog _logger;52 private ILog _logger;
55 private readonly object _loggerLock = new object();53 private readonly object _loggerLock = new object();
56 private static string EventName = "UbuntuOneNotificationIconPresenter";54 private const string EventName = "UbuntuOneNotificationIconPresenter";
57 private static string ApplicationName = "UbuntuOne";55 private const string ApplicationName = "UbuntuOne";
5856
59 #endregion57 #endregion
6058
@@ -167,7 +165,7 @@
167 static NotificationIconPresenter()165 static NotificationIconPresenter()
168 {166 {
169 SharesLocation = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);167 SharesLocation = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
170 SyncsLocation = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments), "UbuntuOne");168 SyncsLocation = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments), Resources.DefaulDirectoryName);
171169
172 }170 }
173171
@@ -243,7 +241,7 @@
243 241
244 Logger.Info("Got the UbuntuOne credentials!");242 Logger.Info("Got the UbuntuOne credentials!");
245 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),243 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
246 "UbuntuOne");244 Resources.DefaulDirectoryName);
247 // ensure that the path can be handled by the python code245 // ensure that the path can be handled by the python code
248 oneDir = oneDir.Replace("\\", "\\\\");246 oneDir = oneDir.Replace("\\", "\\\\");
249 SyncDaemon.ManualSync(247 SyncDaemon.ManualSync(
250248
=== modified file 'src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs'
--- src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs 2010-10-20 11:18:55 +0000
+++ src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs 2010-11-11 11:46:48 +0000
@@ -109,7 +109,7 @@
109 if (args.ApplicationName != EventName) return;109 if (args.ApplicationName != EventName) return;
110 Logger.Info("Got the UbuntuOne credentials!");110 Logger.Info("Got the UbuntuOne credentials!");
111 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),111 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
112 "UbuntuOne");112 Resources.DefaulDirectoryName);
113 // ensure that the path can be handled by the python code113 // ensure that the path can be handled by the python code
114 oneDir = oneDir.Replace("\\", "\\\\");114 oneDir = oneDir.Replace("\\", "\\\\");
115 // call the ISyncService to perform the manual sync115 // call the ISyncService to perform the manual sync
116116
=== modified file 'src/Canonical.UbuntuOne.Client/Preferences/PreferencesDialogPresenter.cs'
--- src/Canonical.UbuntuOne.Client/Preferences/PreferencesDialogPresenter.cs 2010-10-20 11:18:55 +0000
+++ src/Canonical.UbuntuOne.Client/Preferences/PreferencesDialogPresenter.cs 2010-11-11 11:46:48 +0000
@@ -116,7 +116,7 @@
116 if (args.ApplicationName != EventName) return;116 if (args.ApplicationName != EventName) return;
117 Logger.Info("Got the UbuntuOne credentials!");117 Logger.Info("Got the UbuntuOne credentials!");
118 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),118 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
119 "UbuntuOne");119 Resources.DefaulDirectoryName);
120 // ensure that the path can be handled by the python code120 // ensure that the path can be handled by the python code
121 oneDir = oneDir.Replace("\\", "\\\\");121 oneDir = oneDir.Replace("\\", "\\\\");
122 // call the ISyncService to perform the manual sync122 // call the ISyncService to perform the manual sync
123123
=== added file 'src/Canonical.UbuntuOne.Client/Resources.Designer.cs'
--- src/Canonical.UbuntuOne.Client/Resources.Designer.cs 1970-01-01 00:00:00 +0000
+++ src/Canonical.UbuntuOne.Client/Resources.Designer.cs 2010-11-11 11:46:48 +0000
@@ -0,0 +1,72 @@
1//------------------------------------------------------------------------------
2// <auto-generated>
3// This code was generated by a tool.
4// Runtime Version:4.0.30319.1
5//
6// Changes to this file may cause incorrect behavior and will be lost if
7// the code is regenerated.
8// </auto-generated>
9//------------------------------------------------------------------------------
10
11namespace Canonical.UbuntuOne.Client {
12 using System;
13
14
15 /// <summary>
16 /// A strongly-typed resource class, for looking up localized strings, etc.
17 /// </summary>
18 // This class was auto-generated by the StronglyTypedResourceBuilder
19 // class via a tool like ResGen or Visual Studio.
20 // To add or remove a member, edit your .ResX file then rerun ResGen
21 // with the /str option, or rebuild your VS project.
22 [global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "4.0.0.0")]
23 [global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
24 [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
25 internal class Resources {
26
27 private static global::System.Resources.ResourceManager resourceMan;
28
29 private static global::System.Globalization.CultureInfo resourceCulture;
30
31 [global::System.Diagnostics.CodeAnalysis.SuppressMessageAttribute("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
32 internal Resources() {
33 }
34
35 /// <summary>
36 /// Returns the cached ResourceManager instance used by this class.
37 /// </summary>
38 [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
39 internal static global::System.Resources.ResourceManager ResourceManager {
40 get {
41 if (object.ReferenceEquals(resourceMan, null)) {
42 global::System.Resources.ResourceManager temp = new global::System.Resources.ResourceManager("Canonical.UbuntuOne.Client.Resources", typeof(Resources).Assembly);
43 resourceMan = temp;
44 }
45 return resourceMan;
46 }
47 }
48
49 /// <summary>
50 /// Overrides the current thread's CurrentUICulture property for all
51 /// resource lookups using this strongly typed resource class.
52 /// </summary>
53 [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
54 internal static global::System.Globalization.CultureInfo Culture {
55 get {
56 return resourceCulture;
57 }
58 set {
59 resourceCulture = value;
60 }
61 }
62
63 /// <summary>
64 /// Looks up a localized string similar to Ubuntu One.
65 /// </summary>
66 internal static string DefaulDirectoryName {
67 get {
68 return ResourceManager.GetString("DefaulDirectoryName", resourceCulture);
69 }
70 }
71 }
72}
073
=== added file 'src/Canonical.UbuntuOne.Client/Resources.resx'
--- src/Canonical.UbuntuOne.Client/Resources.resx 1970-01-01 00:00:00 +0000
+++ src/Canonical.UbuntuOne.Client/Resources.resx 2010-11-11 11:46:48 +0000
@@ -0,0 +1,123 @@
1<?xml version="1.0" encoding="utf-8"?>
2<root>
3 <!--
4 Microsoft ResX Schema
5
6 Version 2.0
7
8 The primary goals of this format is to allow a simple XML format
9 that is mostly human readable. The generation and parsing of the
10 various data types are done through the TypeConverter classes
11 associated with the data types.
12
13 Example:
14
15 ... ado.net/XML headers & schema ...
16 <resheader name="resmimetype">text/microsoft-resx</resheader>
17 <resheader name="version">2.0</resheader>
18 <resheader name="reader">System.Resources.ResXResourceReader, System.Windows.Forms, ...</resheader>
19 <resheader name="writer">System.Resources.ResXResourceWriter, System.Windows.Forms, ...</resheader>
20 <data name="Name1"><value>this is my long string</value><comment>this is a comment</comment></data>
21 <data name="Color1" type="System.Drawing.Color, System.Drawing">Blue</data>
22 <data name="Bitmap1" mimetype="application/x-microsoft.net.object.binary.base64">
23 <value>[base64 mime encoded serialized .NET Framework object]</value>
24 </data>
25 <data name="Icon1" type="System.Drawing.Icon, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
26 <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
27 <comment>This is a comment</comment>
28 </data>
29
30 There are any number of "resheader" rows that contain simple
31 name/value pairs.
32
33 Each data row contains a name, and value. The row also contains a
34 type or mimetype. Type corresponds to a .NET class that support
35 text/value conversion through the TypeConverter architecture.
36 Classes that don't support this are serialized and stored with the
37 mimetype set.
38
39 The mimetype is used for serialized objects, and tells the
40 ResXResourceReader how to depersist the object. This is currently not
41 extensible. For a given mimetype the value must be set accordingly:
42
43 Note - application/x-microsoft.net.object.binary.base64 is the format
44 that the ResXResourceWriter will generate, however the reader can
45 read any of the formats listed below.
46
47 mimetype: application/x-microsoft.net.object.binary.base64
48 value : The object must be serialized with
49 : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
50 : and then encoded with base64 encoding.
51
52 mimetype: application/x-microsoft.net.object.soap.base64
53 value : The object must be serialized with
54 : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
55 : and then encoded with base64 encoding.
56
57 mimetype: application/x-microsoft.net.object.bytearray.base64
58 value : The object must be serialized into a byte array
59 : using a System.ComponentModel.TypeConverter
60 : and then encoded with base64 encoding.
61 -->
62 <xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
63 <xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
64 <xsd:element name="root" msdata:IsDataSet="true">
65 <xsd:complexType>
66 <xsd:choice maxOccurs="unbounded">
67 <xsd:element name="metadata">
68 <xsd:complexType>
69 <xsd:sequence>
70 <xsd:element name="value" type="xsd:string" minOccurs="0" />
71 </xsd:sequence>
72 <xsd:attribute name="name" use="required" type="xsd:string" />
73 <xsd:attribute name="type" type="xsd:string" />
74 <xsd:attribute name="mimetype" type="xsd:string" />
75 <xsd:attribute ref="xml:space" />
76 </xsd:complexType>
77 </xsd:element>
78 <xsd:element name="assembly">
79 <xsd:complexType>
80 <xsd:attribute name="alias" type="xsd:string" />
81 <xsd:attribute name="name" type="xsd:string" />
82 </xsd:complexType>
83 </xsd:element>
84 <xsd:element name="data">
85 <xsd:complexType>
86 <xsd:sequence>
87 <xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
88 <xsd:element name="comment" type="xsd:string" minOccurs="0" msdata:Ordinal="2" />
89 </xsd:sequence>
90 <xsd:attribute name="name" type="xsd:string" use="required" msdata:Ordinal="1" />
91 <xsd:attribute name="type" type="xsd:string" msdata:Ordinal="3" />
92 <xsd:attribute name="mimetype" type="xsd:string" msdata:Ordinal="4" />
93 <xsd:attribute ref="xml:space" />
94 </xsd:complexType>
95 </xsd:element>
96 <xsd:element name="resheader">
97 <xsd:complexType>
98 <xsd:sequence>
99 <xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
100 </xsd:sequence>
101 <xsd:attribute name="name" type="xsd:string" use="required" />
102 </xsd:complexType>
103 </xsd:element>
104 </xsd:choice>
105 </xsd:complexType>
106 </xsd:element>
107 </xsd:schema>
108 <resheader name="resmimetype">
109 <value>text/microsoft-resx</value>
110 </resheader>
111 <resheader name="version">
112 <value>2.0</value>
113 </resheader>
114 <resheader name="reader">
115 <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
116 </resheader>
117 <resheader name="writer">
118 <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
119 </resheader>
120 <data name="DefaulDirectoryName" xml:space="preserve">
121 <value>Ubuntu One</value>
122 </data>
123</root>
0\ No newline at end of file124\ No newline at end of file

Subscribers

People subscribed via source and target branches

to all changes: