Merge lp:~mandel/ubuntuone-windows-installer/update_daemon_msi into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: Vincenzo Di Somma
Approved revision: 50
Merged at revision: 67
Proposed branch: lp:~mandel/ubuntuone-windows-installer/update_daemon_msi
Merge into: lp:ubuntuone-windows-installer/beta
Prerequisite: lp:~mandel/ubuntuone-windows-installer/implement_db_port_manager
Diff against target: 59 lines (+23/-0)
3 files modified
.bzrignore (+1/-0)
install/UbuntuOne.wxs (+18/-0)
src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj (+4/-0)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/update_daemon_msi
Reviewer Review Type Date Requested Status
Vincenzo Di Somma (community) Approve
Rick McBride (community) Approve
Review via email: mp+32993@code.launchpad.net

Description of the change

Provides updates in the wix code to ensure that the new dependencies from the daemon are installed in the users machine.

To post a comment you must log in.
Revision history for this message
Rick McBride (rmcbride) wrote :

+1,

review: Approve
Revision history for this message
Vincenzo Di Somma (vds) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.bzrignore'
--- .bzrignore 2010-08-18 12:54:43 +0000
+++ .bzrignore 2010-08-18 12:54:43 +0000
@@ -28,3 +28,4 @@
28src/UbuntuOneClient.Tests/obj28src/UbuntuOneClient.Tests/obj
29*.ReSharper29*.ReSharper
30test-results30test-results
31install/UbuntuOne.msi
3132
=== modified file 'install/UbuntuOne.wxs'
--- install/UbuntuOne.wxs 2010-08-04 16:45:17 +0000
+++ install/UbuntuOne.wxs 2010-08-18 12:54:43 +0000
@@ -208,6 +208,22 @@
208 Source="build_results\Daemon\Spring.Services.xml" 208 Source="build_results\Daemon\Spring.Services.xml"
209 KeyPath="yes"/>209 KeyPath="yes"/>
210 </Component>210 </Component>
211 <Component Id="SpringDataComponent"
212 Guid="e1736390-aac1-11df-94e2-0800200c9a66">
213 <File Id="Spring.Data.dll"
214 Name="Spring.Data.dll"
215 DiskId="1"
216 Source="build_results\Daemon\Spring.Data.dll"
217 KeyPath="yes"/>
218 </Component>
219 <Component Id="SymstemDataSQLiteComponent"
220 Guid="43573410-aac2-11df-94e2-0800200c9a66">
221 <File Id="System.Data.SQLite.DLL"
222 Name="System.Data.SQLite.DLL"
223 DiskId="1"
224 Source="build_results\Daemon\System.Data.SQLite.DLL"
225 KeyPath="yes"/>
226 </Component>
211 <Directory Id="DaemonConfigDir"227 <Directory Id="DaemonConfigDir"
212 Name="Config">228 Name="Config">
213 <Component Id="DaemonConfigLog4Net" 229 <Component Id="DaemonConfigLog4Net"
@@ -446,6 +462,8 @@
446 <ComponentRef Id="ServiceModelBehavioursConfig" />462 <ComponentRef Id="ServiceModelBehavioursConfig" />
447 <ComponentRef Id="ServiceModelBindingsConfig" />463 <ComponentRef Id="ServiceModelBindingsConfig" />
448 <ComponentRef Id="ServiceModelServicesConfig" />464 <ComponentRef Id="ServiceModelServicesConfig" />
465 <ComponentRef Id="SpringDataComponent" />
466 <ComponentRef Id="SymstemDataSQLiteComponent" />
449 <!-- Client components -->467 <!-- Client components -->
450 <ComponentRef Id="AvalonLib" />468 <ComponentRef Id="AvalonLib" />
451 <ComponentRef Id="UbuntuOneClientLib" />469 <ComponentRef Id="UbuntuOneClientLib" />
452470
=== modified file 'src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj'
--- src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj 2010-08-18 12:54:43 +0000
+++ src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj 2010-08-18 12:54:43 +0000
@@ -141,6 +141,10 @@
141 </Reference>141 </Reference>
142 <Reference Include="System" />142 <Reference Include="System" />
143 <Reference Include="System.Data" />143 <Reference Include="System.Data" />
144 <Reference Include="System.Data.SQLite, Version=1.0.65.0, Culture=neutral, PublicKeyToken=db937bc2d44ff139, processorArchitecture=x86">
145 <SpecificVersion>False</SpecificVersion>
146 <HintPath>..\..\lib\SQLite\System.Data.SQLite.DLL</HintPath>
147 </Reference>
144 <Reference Include="System.ServiceProcess" />148 <Reference Include="System.ServiceProcess" />
145 <Reference Include="System.Configuration.Install" />149 <Reference Include="System.Configuration.Install" />
146 <Reference Include="System.ServiceModel">150 <Reference Include="System.ServiceModel">

Subscribers

People subscribed via source and target branches

to all changes: