Ubuntu One Windows Installer

Code review comment for lp:~mandel/ubuntuone-windows-installer/systray_integrate_spring

  1. systray_integrate_spring
  2. Merge into beta
Revision history for this message
Stuart Colville (muffinresearch) wrote :

Few warnings:

  [msbuild] (CoreCompile target) ->
  [msbuild] Notification\NotificationIconPresenter.cs(50,58): warning CS0067:
The event 'Canonical.UbuntuOne.Client.Notification.NotificationIconPresenter.OnN
otificationChanged' is never used
  [msbuild] Notification\NotificationIconPresenter.cs(51,51): warning CS0067:
The event 'Canonical.UbuntuOne.Client.Notification.NotificationIconPresenter.OnS
tateChanged' is never used
  [msbuild] Notification\NotificationIconPresenter.cs(52,67): warning CS0067:
The event 'Canonical.UbuntuOne.Client.Notification.NotificationIconPresenter.OnC
ompletenessChanged' is never used
  [msbuild] Notification\NotificationIconPresenter.cs(53,62): warning CS0067:
The event 'Canonical.UbuntuOne.Client.Notification.NotificationIconPresenter.OnR
ecentlyModifiedChanged' is never used
  [msbuild]
  [msbuild] 4 Warning(s)
  [msbuild] 0 Error(s)
  [msbuild]
  [msbuild] Time Elapsed 00:00:17.95

BUILD SUCCEEDED

Otherwise builds and tests ok.

review: Approve

« Back to merge proposal