Merge lp:~mandel/ubuntuone-windows-installer/remove_recently_modifed_state_spaces into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: John Lenton
Approved revision: 163
Merged at revision: 126
Proposed branch: lp:~mandel/ubuntuone-windows-installer/remove_recently_modifed_state_spaces
Merge into: lp:ubuntuone-windows-installer/beta
Prerequisite: lp:~mandel/ubuntuone-windows-installer/use_correct_version
Diff against target: 70 lines (+10/-14)
3 files modified
src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml (+1/-9)
src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml.cs (+8/-4)
src/UbuntuOneClient/Config/log4net.config (+1/-1)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/remove_recently_modifed_state_spaces
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+39905@code.launchpad.net

Description of the change

Remove the not used used ui items.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml'
--- src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml 2010-10-20 23:09:36 +0000
+++ src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml 2010-11-02 22:21:08 +0000
@@ -89,15 +89,7 @@
89 Click="OnOpenSyncMenuItemClick"/>89 Click="OnOpenSyncMenuItemClick"/>
90 <Separator />90 <Separator />
91 <MenuItem Name="StateMenuItem" 91 <MenuItem Name="StateMenuItem"
92 Header="State"/> <!-- Out sync, sync in progress (animate), everything up to date, error -->92 Header="State"/>
93 <MenuItem Name="CompleteInfoMenuItem"
94 Header=""/>
95 <MenuItem Name="SpaceLeftMenuItem"
96 Header=""/>
97 <Separator />
98 <MenuItem x:Uid="RecentlyModifyFilesMenuItem"
99 Name="RecentlyModifyFilesMenuItem"
100 Header="{x:Static resx:Resources.NotificationIconRecentlyModifyFilesLabel}" />
101 <Separator />93 <Separator />
102 <MenuItem x:Uid="HelpMenuItem" 94 <MenuItem x:Uid="HelpMenuItem"
103 Name="HelpMenuItem" 95 Name="HelpMenuItem"
10496
=== modified file 'src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml.cs'
--- src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml.cs 2010-10-20 23:09:36 +0000
+++ src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml.cs 2010-11-02 22:21:08 +0000
@@ -62,8 +62,8 @@
62 public bool IsManualSyncEnabled62 public bool IsManualSyncEnabled
63 {63 {
64 get { return UbuntuOneManualSync.IsEnabled; }64 get { return UbuntuOneManualSync.IsEnabled; }
65 set 65 set
66 { 66 {
67 UbuntuOneManualSync.IsEnabled = value;67 UbuntuOneManualSync.IsEnabled = value;
68 if (!UbuntuOneManualSync.IsEnabled)68 if (!UbuntuOneManualSync.IsEnabled)
69 {69 {
@@ -104,7 +104,11 @@
104 public string State104 public string State
105 {105 {
106 get { return (string)StateMenuItem.Header; }106 get { return (string)StateMenuItem.Header; }
107 set { StateMenuItem.Header = value; }107 set
108 {
109 StateMenuItem.Header = value;
110 Title = value;
111 }
108 }112 }
109113
110 /// <summary>114 /// <summary>
@@ -125,7 +129,7 @@
125 {129 {
126 get130 get
127 {131 {
128 if(_dispatcher == null)132 if (_dispatcher == null)
129 {133 {
130 lock (_dispatcherLock)134 lock (_dispatcherLock)
131 {135 {
132136
=== modified file 'src/UbuntuOneClient/Config/log4net.config'
--- src/UbuntuOneClient/Config/log4net.config 2010-10-20 14:28:58 +0000
+++ src/UbuntuOneClient/Config/log4net.config 2010-11-02 22:21:08 +0000
@@ -2,7 +2,7 @@
2<log4net>2<log4net>
3 <appender name="RollingFileAppender"3 <appender name="RollingFileAppender"
4 type="log4net.Appender.RollingFileAppender">4 type="log4net.Appender.RollingFileAppender">
5 <file value="~/Logs/Client.log" />5 <file value="Logs/Client.log" />
6 <appendToFile value="true" />6 <appendToFile value="true" />
7 <rollingStyle value="Size" />7 <rollingStyle value="Size" />
8 <maxSizeRollBackups value="10" />8 <maxSizeRollBackups value="10" />

Subscribers

People subscribed via source and target branches

to all changes: