Merge lp:~mandel/ubuntuone-windows-installer/open_preferences_after_adding_machine into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: John Lenton
Approved revision: 179
Merged at revision: 137
Proposed branch: lp:~mandel/ubuntuone-windows-installer/open_preferences_after_adding_machine
Merge into: lp:ubuntuone-windows-installer/beta
Prerequisite: lp:~mandel/ubuntuone-windows-installer/smart_context_menu
Diff against target: 71 lines (+44/-7) (has conflicts)
1 file modified
src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs (+44/-7)
Text conflict in src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/open_preferences_after_adding_machine
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+40820@code.launchpad.net

Description of the change

Open preferences after adding the machine.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs'
--- src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs 2010-11-14 22:48:11 +0000
+++ src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs 2010-11-14 22:48:12 +0000
@@ -239,16 +239,17 @@
239 {239 {
240 // we got credentials, no matter what we tell the ui to be ready240 // we got credentials, no matter what we tell the ui to be ready
241 NotificationIconView.ViewDispatcher.Dispatch(() => NotificationIconView.ShowAsAddedComputer(true));241 NotificationIconView.ViewDispatcher.Dispatch(() => NotificationIconView.ShowAsAddedComputer(true));
242 // check if the credentials are for us);242 // check if the credentials are for us
243 if (args.ApplicationName != ManualSyncEvent) return;243<<<<<<< TREE
244 if (args.ApplicationName != EventName) return;
244 NotificationIconView.ViewDispatcher.Dispatch(245 NotificationIconView.ViewDispatcher.Dispatch(
245 () =>246 () =>
246 {247 {
247 NotificationIconView.IsManualSyncEnabled = false;248 NotificationIconView.IsManualSyncEnabled = false;
248 NotificationIconView.State = "Syncing";249 NotificationIconView.State = "Syncing";
249 }250 }
250 );251 );
251252
252 Logger.Info("Got the UbuntuOne credentials!");253 Logger.Info("Got the UbuntuOne credentials!");
253 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),254 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
254 Resources.DefaulDirectoryName);255 Resources.DefaulDirectoryName);
@@ -267,6 +268,42 @@
267 NotificationIconView.State = "Synced";268 NotificationIconView.State = "Synced";
268 }269 }
269 );270 );
271=======
272 if (args.ApplicationName == ManualSyncEvent)
273 {
274 NotificationIconView.ViewDispatcher.Dispatch(
275 () =>
276 {
277 NotificationIconView.IsManualSyncEnabled = false;
278 NotificationIconView.State = "Syncing";
279 }
280 );
281
282 Logger.Info("Got the UbuntuOne credentials!");
283 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
284 "UbuntuOne");
285 // ensure that the path can be handled by the python code
286 oneDir = oneDir.Replace("\\", "\\\\");
287 SyncDaemon.ManualSync(
288 oneDir,
289 args.Credentials["Token"],
290 args.Credentials["TokenSecret"],
291 args.Credentials["ConsumerKey"],
292 args.Credentials["ConsumerSecret"]);
293 NotificationIconView.ViewDispatcher.Dispatch(
294 () =>
295 {
296 NotificationIconView.IsManualSyncEnabled = true;
297 NotificationIconView.State = "Synced";
298 }
299 );
300 }// manual sync
301 if(args.ApplicationName == AddComputerEvent)
302 {
303 // show the preferences since it is the first time we use the app
304 PreferencesDialogPresenter.Show();
305 }
306>>>>>>> MERGE-SOURCE
270 }307 }
271308
272 [DebugLogged]309 [DebugLogged]

Subscribers

People subscribed via source and target branches

to all changes: