Ubuntu One Windows Installer

Code review comment for lp:~mandel/ubuntuone-windows-installer/migrate-data

  1. migrate-data
  2. Merge into trunk
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Code looks good, pasting a few minor fixes I discussed with mandel in the IRC channel:

(01:02:32 PM) nessita: mandel: for future references, this is not valid pep8 styling for lists: ['Music', 'Photos', 'Personal', ] it should be ['Music', 'Photos', 'Personal']
(01:03:17 PM) mandel: nessita, the problem is the last ',' right?
(01:03:26 PM) nessita: mandel: and the last space
(01:03:40 PM) nessita: so, the exta ", " should not be there

(01:07:04 PM) nessita: from ubuntuone.platform.windows import tools
(01:07:12 PM) nessita: I mentioned you should not import from windows but from:
(01:07:16 PM) nessita: from ubuntuone.platform import tools

Thanks!

review: Approve

« Back to merge proposal