Code review comment for lp:~mandel/ubuntuone-windows-installer/migrate-data

A couple of fixes:

* Instead of importing from windows, which should be a 'hidden' module:

from ubuntuone.platform.windows import recursive_move, listdir, tools

import from platform directly:

from ubuntuone.platform import recursive_move, listdir, tools

* Can you please remove the duplication of the code calculating the path to the Documents folder? can you replace the logic in migrate_old_data() with a call to get_special_folders()[0]?

* I think the migration of old data should remove the old metadata. Can we do that?

* Also, the user should be prompt to confirm if s/he wants to the migration to happen, no?

* If I understand the code correctly, you're overwriting all the files inside the new location. We should check if we're about to overwrite a file and handle that case gracefully (probably adding a suffix to the old file, we should ask Lisette).