Merge lp:~mandel/ubuntuone-windows-installer/fix_help_space into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: Rick McBride
Approved revision: 94
Merged at revision: 95
Proposed branch: lp:~mandel/ubuntuone-windows-installer/fix_help_space
Merge into: lp:ubuntuone-windows-installer/beta
Prerequisite: lp:~mandel/ubuntuone-windows-installer/fix_648595
Diff against target: 38 lines (+14/-2)
2 files modified
src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml (+4/-2)
src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml.cs (+10/-0)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/fix_help_space
Reviewer Review Type Date Requested Status
Rick McBride (community) Approve
John Lenton (community) Approve
Review via email: mp+37649@code.launchpad.net

Description of the change

Fixes lp:655286 and lp:655292 by connecting the view with the presenter.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) :
review: Approve
Revision history for this message
Rick McBride (rmcbride) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml'
--- src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml 2010-10-05 18:19:18 +0000
+++ src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml 2010-10-05 18:19:18 +0000
@@ -62,10 +62,12 @@
62 <Separator />62 <Separator />
63 <MenuItem x:Uid="HelpMenuItem" 63 <MenuItem x:Uid="HelpMenuItem"
64 Name="HelpMenuItem" 64 Name="HelpMenuItem"
65 Header="{x:Static resx:Resources.Help}" />65 Header="{x:Static resx:Resources.Help}"
66 Click="HelpMenuItemClick"/>
66 <MenuItem x:Uid="MoreSpaceMenuItem" 67 <MenuItem x:Uid="MoreSpaceMenuItem"
67 Name="MoreSpaceMenuItem" 68 Name="MoreSpaceMenuItem"
68 Header="{x:Static resx:Resources.MoreSpace}"/>69 Header="{x:Static resx:Resources.MoreSpace}"
70 Click="MoreSpaceMenuItemClick"/>
69 <MenuItem x:Uid="ExitMenuItem" 71 <MenuItem x:Uid="ExitMenuItem"
70 Name="ExitMenuItem" 72 Name="ExitMenuItem"
71 Header="{x:Static resx:Resources.Exit}" 73 Header="{x:Static resx:Resources.Exit}"
7274
=== modified file 'src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml.cs'
--- src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml.cs 2010-10-05 18:19:18 +0000
+++ src/Canonical.UbuntuOne.Client.Views/NotifyIcon.xaml.cs 2010-10-05 18:19:18 +0000
@@ -95,5 +95,15 @@
95 {95 {
96 NotificationIconPresenter.Exit();96 NotificationIconPresenter.Exit();
97 }97 }
98
99 private void HelpMenuItemClick(object sender, System.Windows.RoutedEventArgs e)
100 {
101 NotificationIconPresenter.OpenHelp();
102 }
103
104 private void MoreSpaceMenuItemClick(object sender, System.Windows.RoutedEventArgs e)
105 {
106 NotificationIconPresenter.OpenUpgradeOption();
107 }
98 }108 }
99}109}

Subscribers

People subscribed via source and target branches

to all changes: