Merge lp:~mandel/ubuntuone-windows-installer/fix_628160 into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: Rick McBride
Approved revision: 96
Merged at revision: 96
Proposed branch: lp:~mandel/ubuntuone-windows-installer/fix_628160
Merge into: lp:ubuntuone-windows-installer/beta
Prerequisite: lp:~mandel/ubuntuone-windows-installer/fix_help_space
Diff against target: 29 lines (+8/-0)
2 files modified
install/UbuntuOne7.wxs (+4/-0)
install/UbuntuOneXP.wxs (+4/-0)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/fix_628160
Reviewer Review Type Date Requested Status
Rick McBride (community) Approve
John Lenton (community) Approve
Review via email: mp+37656@code.launchpad.net

Description of the change

Fixes lp:628160 by telling the user the need to reboot the machine.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) :
review: Approve
Revision history for this message
Rick McBride (rmcbride) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'install/UbuntuOne7.wxs'
--- install/UbuntuOne7.wxs 2010-10-05 19:52:40 +0000
+++ install/UbuntuOne7.wxs 2010-10-05 19:52:41 +0000
@@ -1037,6 +1037,10 @@
1037 <ComponentRef Id="Newtonsoft.Json" />1037 <ComponentRef Id="Newtonsoft.Json" />
1038 </Feature>1038 </Feature>
1039 1039
1040 <InstallExecuteSequence>
1041 <ScheduleReboot After='InstallFinalize' />
1042 </InstallExecuteSequence>
1043
1040 <UI Id="WixUI_Minimal_No_License">1044 <UI Id="WixUI_Minimal_No_License">
1041 <TextStyle Id="WixUI_Font_Normal" FaceName="Tahoma" Size="8" />1045 <TextStyle Id="WixUI_Font_Normal" FaceName="Tahoma" Size="8" />
1042 <TextStyle Id="WixUI_Font_Bigger" FaceName="Tahoma" Size="12" />1046 <TextStyle Id="WixUI_Font_Bigger" FaceName="Tahoma" Size="12" />
10431047
=== modified file 'install/UbuntuOneXP.wxs'
--- install/UbuntuOneXP.wxs 2010-10-05 19:52:40 +0000
+++ install/UbuntuOneXP.wxs 2010-10-05 19:52:41 +0000
@@ -809,6 +809,10 @@
809 <ComponentRef Id="Newtonsoft.Json" />809 <ComponentRef Id="Newtonsoft.Json" />
810 </Feature>810 </Feature>
811 811
812 <InstallExecuteSequence>
813 <ScheduleReboot After='InstallFinalize' />
814 </InstallExecuteSequence>
815
812 <UI Id="WixUI_Minimal_No_License">816 <UI Id="WixUI_Minimal_No_License">
813 <TextStyle Id="WixUI_Font_Normal" FaceName="Tahoma" Size="8" />817 <TextStyle Id="WixUI_Font_Normal" FaceName="Tahoma" Size="8" />
814 <TextStyle Id="WixUI_Font_Bigger" FaceName="Tahoma" Size="12" />818 <TextStyle Id="WixUI_Font_Bigger" FaceName="Tahoma" Size="12" />

Subscribers

People subscribed via source and target branches

to all changes: