Merge lp:~mandel/ubuntuone-windows-installer/connect_to_ubuntuone into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: John Lenton
Approved revision: 107
Merged at revision: 135
Proposed branch: lp:~mandel/ubuntuone-windows-installer/connect_to_ubuntuone
Merge into: lp:ubuntuone-windows-installer/beta
Diff against target: 78 lines (+30/-6)
3 files modified
src/Canonical.Ubuntu.SSO.Views/LoginDialog.xaml (+4/-4)
src/Canonical.Ubuntu.SSO.Views/Resources/Resources.Designer.cs (+18/-0)
src/Canonical.Ubuntu.SSO.Views/Resources/Resources.resx (+8/-2)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/connect_to_ubuntuone
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+40819@code.launchpad.net

Description of the change

Changed the login view to use the data from the resource file and added the correct text.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Canonical.Ubuntu.SSO.Views/LoginDialog.xaml'
--- src/Canonical.Ubuntu.SSO.Views/LoginDialog.xaml 2010-10-05 15:20:36 +0000
+++ src/Canonical.Ubuntu.SSO.Views/LoginDialog.xaml 2010-11-14 22:06:14 +0000
@@ -61,11 +61,11 @@
61 <Grid Grid.Row="1">61 <Grid Grid.Row="1">
62 <Grid.ColumnDefinitions>62 <Grid.ColumnDefinitions>
63 <ColumnDefinition Width="*"/>63 <ColumnDefinition Width="*"/>
64 <ColumnDefinition Width="85"/>64 <ColumnDefinition Width="Auto"/>
65 <ColumnDefinition Width="85"/>65 <ColumnDefinition Width="Auto"/>
66 </Grid.ColumnDefinitions>66 </Grid.ColumnDefinitions>
67 <Button Name="LoginButton" Grid.Column="1" Margin="3" Click="ConnectButtonClick">Connect</Button>67 <Button Name="LoginButton" Grid.Column="1" Margin="3" Click="ConnectButtonClick" Content="{x:Static resx:Resources.LoginViewConnectButtonText}"/>
68 <Button Name="CancelButton" Grid.Column="2" Margin="3" Click="CancelButtonClick">Cancel</Button>68 <Button Name="CancelButton" Grid.Column="2" Margin="3" Click="CancelButtonClick" Content="{x:Static resx:Resources.LoginViewCancelButtonText}"/>
69 </Grid>69 </Grid>
70 </Grid>70 </Grid>
71</Window>71</Window>
7272
=== modified file 'src/Canonical.Ubuntu.SSO.Views/Resources/Resources.Designer.cs'
--- src/Canonical.Ubuntu.SSO.Views/Resources/Resources.Designer.cs 2010-10-12 12:42:38 +0000
+++ src/Canonical.Ubuntu.SSO.Views/Resources/Resources.Designer.cs 2010-11-14 22:06:14 +0000
@@ -88,6 +88,24 @@
88 }88 }
89 89
90 /// <summary>90 /// <summary>
91 /// Looks up a localized string similar to Cancel.
92 /// </summary>
93 public static string LoginViewCancelButtonText {
94 get {
95 return ResourceManager.GetString("LoginViewCancelButtonText", resourceCulture);
96 }
97 }
98
99 /// <summary>
100 /// Looks up a localized string similar to Connect to Ubuntu One.
101 /// </summary>
102 public static string LoginViewConnectButtonText {
103 get {
104 return ResourceManager.GetString("LoginViewConnectButtonText", resourceCulture);
105 }
106 }
107
108 /// <summary>
91 /// Looks up a localized string similar to To connect this computer to Ubuntu One enter your details below..109 /// Looks up a localized string similar to To connect this computer to Ubuntu One enter your details below..
92 /// </summary>110 /// </summary>
93 public static string LoginViewInfo {111 public static string LoginViewInfo {
94112
=== modified file 'src/Canonical.Ubuntu.SSO.Views/Resources/Resources.resx'
--- src/Canonical.Ubuntu.SSO.Views/Resources/Resources.resx 2010-10-05 11:19:52 +0000
+++ src/Canonical.Ubuntu.SSO.Views/Resources/Resources.resx 2010-11-14 22:06:14 +0000
@@ -112,10 +112,10 @@
112 <value>2.0</value>112 <value>2.0</value>
113 </resheader>113 </resheader>
114 <resheader name="reader">114 <resheader name="reader">
115 <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>115 <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
116 </resheader>116 </resheader>
117 <resheader name="writer">117 <resheader name="writer">
118 <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>118 <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
119 </resheader>119 </resheader>
120 <data name="LoginEmailAddressWatermark" xml:space="preserve">120 <data name="LoginEmailAddressWatermark" xml:space="preserve">
121 <value>Email address</value>121 <value>Email address</value>
@@ -126,6 +126,12 @@
126 <data name="LoginPasswordWatermark" xml:space="preserve">126 <data name="LoginPasswordWatermark" xml:space="preserve">
127 <value>Password</value>127 <value>Password</value>
128 </data>128 </data>
129 <data name="LoginViewCancelButtonText" xml:space="preserve">
130 <value>Cancel</value>
131 </data>
132 <data name="LoginViewConnectButtonText" xml:space="preserve">
133 <value>Connect to Ubuntu One</value>
134 </data>
129 <data name="LoginViewInfo" xml:space="preserve">135 <data name="LoginViewInfo" xml:space="preserve">
130 <value>To connect this computer to Ubuntu One enter your details below.</value>136 <value>To connect this computer to Ubuntu One enter your details below.</value>
131 </data>137 </data>

Subscribers

People subscribed via source and target branches

to all changes: