Ubuntu One Windows Installer

Code review comment for lp:~mandel/ubuntuone-windows-installer/auto-update-python-only

  1. auto-update-python-only
  2. Merge into trunk
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

...
ubuntuone_installer.gui.qt.main.tests.test_windows
  CredsFailureMainTestCase
    test_failure ... [OK]
    test_no_creds ... Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "X:\ubuntuone-windows-installer-mandel\ubuntuone_installer\gui\qt\main\wi
ndows.py", line 85, in check_credentials
    success_cb(creds, gui, installer, logger)
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1141, in
unwindGenerator
    return _inlineCallbacks(None, f(*args, **kwargs), Deferred())
  File "X:\ubuntuone-windows-installer-mandel\ubuntuone_installer\gui\qt\main\wi
ndows.py", line 50, in success_cb
    logger.debug('Got back from sso.')
exceptions.AttributeError: 'FakeLogger' object has no attribute 'debug'
[ERROR]
    test_with_creds ... Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "X:\ubuntuone-windows-installer-mandel\ubuntuone_installer\gui\qt\main\wi
ndows.py", line 85, in check_credentials
    success_cb(creds, gui, installer, logger)
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1141, in
unwindGenerator
    return _inlineCallbacks(None, f(*args, **kwargs), Deferred())
  File "X:\ubuntuone-windows-installer-mandel\ubuntuone_installer\gui\qt\main\wi
ndows.py", line 50, in success_cb
    logger.debug('Got back from sso.')
exceptions.AttributeError: 'FakeLogger' object has no attribute 'debug'
[ERROR]
    test_with_installed_flag ... Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "X:\ubuntuone-windows-installer-mandel\ubuntuone_installer\gui\qt\main\te
sts\test_windows.py", line 150, in test_with_installed_flag
    gui, True), {}))
twisted.trial.unittest.FailTest: not equal:
a = (('Something not false',
  <module 'ubuntuone_installer.gui.qt.gui' from 'X:\ubuntuone-windows-installer-
mandel\ubuntuone_installer\gui\qt\gui.pyc'>,
  True,
  <ubuntuone_installer.gui.qt.main.tests.test_windows.FakeLogger object at 0x086
9D3B0>),
 {})
b = (('Something not false',
  <module 'ubuntuone_installer.gui.qt.gui' from 'X:\ubuntuone-windows-installer-
mandel\ubuntuone_installer\gui\qt\gui.pyc'>,
  True),
 {})

[FAIL]
    test_without_installed_flag ... Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "X:\ubuntuone-windows-installer-mandel\ubuntuone_installer\gui\qt\main\te
sts\test_windows.py", line 139, in test_without_installed_flag
    gui, False), {}))
twisted.trial.unittest.FailTest: not equal:
a = (('Something not false',
  <module 'ubuntuone_installer.gui.qt.gui' from 'X:\ubuntuone-windows-installer-
mandel\ubuntuone_installer\gui\qt\gui.pyc'>,
  False,
  <ubuntuone_installer.gui.qt.main.tests.test_windows.FakeLogger object at 0x086
9D9B0>),
 {})
b = (('Something not false',
  <module 'ubuntuone_installer.gui.qt.gui' from 'X:\ubuntuone-windows-installer-
mandel\ubuntuone_installer\gui\qt\gui.pyc'>,
  False),
 {})

[FAIL]
ubuntuone_installer.tests
  TestCase
    runTest ... [OK]

===============================================================================
[FAIL]
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "X:\ubuntuone-windows-installer-mandel\ubuntuone_installer\gui\qt\main\te
sts\test_windows.py", line 150, in test_with_installed_flag
    gui, True), {}))
twisted.trial.unittest.FailTest: not equal:
a = (('Something not false',
  <module 'ubuntuone_installer.gui.qt.gui' from 'X:\ubuntuone-windows-installer-
mandel\ubuntuone_installer\gui\qt\gui.pyc'>,
  True,
  <ubuntuone_installer.gui.qt.main.tests.test_windows.FakeLogger object at 0x086
9D3B0>),
 {})
b = (('Something not false',
  <module 'ubuntuone_installer.gui.qt.gui' from 'X:\ubuntuone-windows-installer-
mandel\ubuntuone_installer\gui\qt\gui.pyc'>,
  True),
 {})

ubuntuone_installer.gui.qt.main.tests.test_windows.CredsFailureMainTestCase.test
_with_installed_flag
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "X:\ubuntuone-windows-installer-mandel\ubuntuone_installer\gui\qt\main\te
sts\test_windows.py", line 139, in test_without_installed_flag
    gui, False), {}))
twisted.trial.unittest.FailTest: not equal:
a = (('Something not false',
  <module 'ubuntuone_installer.gui.qt.gui' from 'X:\ubuntuone-windows-installer-
mandel\ubuntuone_installer\gui\qt\gui.pyc'>,
  False,
  <ubuntuone_installer.gui.qt.main.tests.test_windows.FakeLogger object at 0x086
9D9B0>),
 {})
b = (('Something not false',
  <module 'ubuntuone_installer.gui.qt.gui' from 'X:\ubuntuone-windows-installer-
mandel\ubuntuone_installer\gui\qt\gui.pyc'>,
  False),
 {})

ubuntuone_installer.gui.qt.main.tests.test_windows.CredsFailureMainTestCase.test
_without_installed_flag
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "X:\ubuntuone-windows-installer-mandel\ubuntuone_installer\gui\qt\main\wi
ndows.py", line 85, in check_credentials
    success_cb(creds, gui, installer, logger)
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1141, in
unwindGenerator
    return _inlineCallbacks(None, f(*args, **kwargs), Deferred())
  File "X:\ubuntuone-windows-installer-mandel\ubuntuone_installer\gui\qt\main\wi
ndows.py", line 50, in success_cb
    logger.debug('Got back from sso.')
exceptions.AttributeError: 'FakeLogger' object has no attribute 'debug'

ubuntuone_installer.gui.qt.main.tests.test_windows.CredsFailureMainTestCase.test
_no_creds
ubuntuone_installer.gui.qt.main.tests.test_windows.CredsFailureMainTestCase.test
_with_creds
-------------------------------------------------------------------------------
Ran 153 tests in 9.213s

FAILED (failures=2, errors=2, successes=149)

review: Needs Fixing

« Back to merge proposal