77 + ex = self.assertRaises(squid.SquidLaunchError, 78 + self.runner.start_service)
In the diff, this second line is spaced over very far to the right. Why is that?
12 + msg = 'Could not start squid: %s, %s' % (output, err)
I don't think this formatting is correct. As stdout and stderr may contain multiple lines, this formatting will reduce readability slightly. I think you should do "\n%s\n%s" instead of "%s, %s" here.
« Back to merge proposal
77 + ex = self.assertRais es(squid. SquidLaunchErro r, start_service)
78 + self.runner.
In the diff, this second line is spaced over very far to the right. Why is that?
12 + msg = 'Could not start squid: %s, %s' % (output, err)
I don't think this formatting is correct. As stdout and stderr may contain multiple lines, this formatting will reduce readability slightly. I think you should do "\n%s\n%s" instead of "%s, %s" here.