Code review comment for lp:~mandel/ubuntuone-dev-tools/refactor-testcase

The attempt to merge lp:~mandel/ubuntuone-dev-tools/refactor-testcase into lp:ubuntuone-dev-tools failed. Below is the output from the failed tests.

ubuntuone.devtools.testcases.dbus
  DBusTestCase
    runTest ... [OK]
ubuntuone.devtools.services.tests.test_dbus
  TestWithDBus
    test_config_file_path ... [OK]
    test_dbus_session_is_running ... [OK]
ubuntuone.devtools.testcases
  BaseTestCase
    runTest ... [OK]
ubuntuone.devtools.tests.test_decorators
  TestSkipBasicDecorators
    test_skip_class ... [OK]
    test_skip_decorators ... [OK]
ubuntuone.devtools.tests.test_txcheck
  TestCheckTwistedTestClass
    test_bad_mixin_order ... [OK]
    test_bare_super ... [OK]
    test_inline_callbacks ... [OK]
    test_inline_callbacks_missing ... [OK]
    test_missing_return ... [OK]
    test_no_problems ... [OK]
    test_not_twisted ... [OK]
    test_ok_mixin_order ... [OK]
    test_super_not_called ... [OK]
  TestTwistedCheckSuite
    test_suite_catches_problems ... [OK]
    test_suite_runs_tests ... [OK]
twisted.trial.unittest
  TestCase
    runTest ... [OK]

-------------------------------------------------------------------------------
Ran 18 tests in 0.259s

PASSED (successes=18)
Name Stmts Exec Cover
-----------------------------------------------------------------
ubuntuone/__init__ 1 0 0%
ubuntuone/devtools/__init__ 0 0 100%
ubuntuone/devtools/handlers 30 0 0%
ubuntuone/devtools/reactors/__init__ 0 0 100%
ubuntuone/devtools/reactors/glib 7 0 0%
ubuntuone/devtools/reactors/qt4 11 0 0%
ubuntuone/devtools/reactors/twisted 2 0 0%
ubuntuone/devtools/reactors/txnp 4 0 0%
ubuntuone/devtools/services/__init__ 0 0 100%
ubuntuone/devtools/services/dbus 58 33 56%
ubuntuone/devtools/services/tests/__init__ 0 0 100%
ubuntuone/devtools/services/tests/test_dbus 16 8 50%
ubuntuone/devtools/testcase 4 0 0%
ubuntuone/devtools/testcases/__init__ 77 27 35%
ubuntuone/devtools/testcases/dbus 42 14 33%
ubuntuone/devtools/testing/__init__ 0 0 100%
ubuntuone/devtools/testing/txcheck 174 109 62%
ubuntuone/devtools/tests/__init__ 0 0 100%
ubuntuone/devtools/tests/test_decorators 37 25 67%
ubuntuone/devtools/tests/test_txcheck 100 68 68%
-----------------------------------------------------------------
TOTAL 563 284 50%
ubuntuone.devtools.testcases.dbus
  DBusTestCase
    runTest ... [OK]
ubuntuone.devtools.services.tests.test_dbus
  TestWithDBus
    test_config_file_path ... [OK]
    test_dbus_session_is_running ... [OK]
ubuntuone.devtools.testcases
  BaseTestCase
    runTest ... [OK]
ubuntuone.devtools.tests.test_decorators
  TestSkipBasicDecorators
    test_skip_class ... [OK]
    test_skip_decorators ... [OK]
ubuntuone.devtools.tests.test_txcheck
  TestCheckTwistedTestClass
    test_bad_mixin_order ... [OK]
    test_bare_super ... [OK]
    test_inline_callbacks ... [OK]
    test_inline_callbacks_missing ... [OK]
    test_missing_return ... [OK]
    test_no_problems ... [OK]
    test_not_twisted ... [OK]
    test_ok_mixin_order ... [OK]
    test_super_not_called ... [OK]
  TestTwistedCheckSuite
    test_suite_catches_problems ... [OK]
    test_suite_runs_tests ... [OK]
twisted.trial.unittest
  TestCase
    runTest ... [OK]

-------------------------------------------------------------------------------
Ran 18 tests in 0.032s

PASSED (successes=18)
Running style checks...
== Python Lint Notices ==

bin/u1lint:
    242: [W0511] XXX Testing that W0511 does not cause a failure

ubuntuone/devtools/testcases/dbus.py:
    26: [W0611] Unused import skipIf

/home/tarmac/cache/ubuntuone-dev-tools/trunk/ubuntuone/devtools/services/tests/test_dbus.py:6: DeprecationWarning: Deprecated import path; use ubuntuone.devtools.testcasesinstead.
  from ubuntuone.devtools.testcase import DBusTestCase
/home/tarmac/cache/ubuntuone-dev-tools/trunk/ubuntuone/devtools/services/tests/test_dbus.py:6: DeprecationWarning: Deprecated import path; use ubuntuone.devtools.testcasesinstead.
  from ubuntuone.devtools.testcase import DBusTestCase
/usr/lib/pymodules/python2.6/pylint/lint.py:368: DeprecationWarning: disable-msg is deprecated, replace it by disable (/home/tarmac/cache/ubuntuone-dev-tools/trunk/ubuntuone/devtools/testing/txcheck.py)
  DeprecationWarning)
/usr/lib/pymodules/python2.6/pylint/lint.py:368: DeprecationWarning: disable-msg is deprecated, replace it by disable (/home/tarmac/cache/ubuntuone-dev-tools/trunk/ubuntuone/devtools/tests/test_txcheck.py)
  DeprecationWarning)