Code review comment for lp:~mandel/ubuntuone-dev-tools/mocked-webserver

Revision history for this message
Alejandro J. Cura (alecu) wrote :

Nice branch. This is a very good second step in order to reduce the amount of boilerplate we have everywhere in our tests.

The only bit I don't like is the many "if self.ssl_settings" scattered around.
What about splitting the WebServer class into HTTPS and HTTP classes?

review: Needs Fixing

« Back to merge proposal