Code review comment for lp:~mandel/ubuntuone-dev-tools/allow_txnamedpipes_reactor

Revision history for this message
dobey (dobey) wrote :

+NAMEDPIPES_REACTOR_PROJECT = 'lp:txnamedpipes'

This really should be a useful HTTP[S] URL instead. Something people can click on and get to a web page, as with the Qt reactor one.

Also, the ./run-tests now fails for me on Linux in this branch.

I think I would also prefer to have a --reactor={glib,qt,namedpipes} type of argument to specify the reactor, than constantly adding more --foo-reactor arguments for every one we add. And then also have some of them perhaps provide additional argument possibilities, such as --with-ui for the Qt reactor, so that proper things can be done there. Perhaps it is time to move the reactor handling into their own modules, so we can treat them like plug-ins and make this main code a little more generic.

review: Needs Fixing

« Back to merge proposal