Code review comment for lp:~mandel/ubuntuone-control-panel/auto-update-looping-call

Manuel de la Peña (mandel) wrote :

I have applied changes to the code to simplify the move away from the qt4reactor, please let me know if they are goo enough:

* Removed the import of stop in the systray (present in trunk). Because we pass the stop function to main lets just foward that to systray.
* Added a LoopingCall object that uses QTimer for linux since we won't be using the reactor. Added tests to ensure if works as a LoopingCall (including same assert exceptions.)
* dos2unix used in the files with windows EOL.

« Back to merge proposal