* addCleanup supports passing arguments next to the function, so instead of
+ self.addCleanup(lambda: self._reset_frozen_state(old_frozen, + old_exec_path))
you just have to call:
+ self.addCleanup(self._reset_frozen_state, old_frozen, old_exec_path)
Same for:
+ self.addCleanup(lambda: self._reset__file__(old_file))
+ self.addCleanup(self._reset__file__, old_file)
* On ubuntuone/controlpanel/utils/windows.py, define logger globally so is accessible to the whole module, and to also maintain consistency with the rest of the project.
The rest looks good!
« Back to merge proposal
* addCleanup supports passing arguments next to the function, so instead of
+ self.addCleanup (lambda: self._reset_ frozen_ state(old_ frozen,
+ old_exec_path))
you just have to call:
+ self.addCleanup (self._ reset_frozen_ state, old_frozen, old_exec_path)
Same for:
+ self.addCleanup (lambda: self._reset_ _file__ (old_file) )
you just have to call:
+ self.addCleanup (self._ reset__ file__, old_file)
* On ubuntuone/ controlpanel/ utils/windows. py, define logger globally so is accessible to the whole module, and to also maintain consistency with the rest of the project.
The rest looks good!