Code review comment for lp:~mandel/ubuntuone-control-panel/auto-update-functions

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

* addCleanup supports passing arguments next to the function, so instead of

+ self.addCleanup(lambda: self._reset_frozen_state(old_frozen,
+ old_exec_path))

you just have to call:

+ self.addCleanup(self._reset_frozen_state, old_frozen, old_exec_path)

Same for:

+ self.addCleanup(lambda: self._reset__file__(old_file))

you just have to call:

+ self.addCleanup(self._reset__file__, old_file)

* On ubuntuone/controlpanel/utils/windows.py, define logger globally so is accessible to the whole module, and to also maintain consistency with the rest of the project.

The rest looks good!

review: Needs Fixing

« Back to merge proposal