Code review comment for lp:~mandel/ubuntuone-client/windows_sdtool

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

* In order to really handle all the possible errors in UbuntuOneClient.connect, please add to it the inlineCallbacks decorator and change:

            d = self.factory.getRootObject()
            d.addCallback(self._request_remote_objects)
            return d

for:

            yield self.factory.getRootObject()
            yield self._request_remote_objects

* We need tests for the SDTool...

review: Needs Fixing

« Back to merge proposal