Code review comment for lp:~mandel/ubuntuone-client/illegal_windows_chars

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

* Unless I'm missing something, seems like the custom logic to separate the drive letter has not been replaced by os.path.splitdrive.

* All the logger.exception calls should not add the exception itself to the message string since is automatically added by the logger. So, a sentence like this:

        logger.exception('Goet exception %s when setting path %s to no rights',
                         e, path)

should be:

        logger.exception('Got exception when setting path %s to no rights:', path)

* As Alejandro mentioned, there are some new trailing spaces added by this branch, please remove that.

review: Needs Fixing

« Back to merge proposal