* You're adding a lot of duplication for the tests. What about creating a new assert method and reuse that in every test?
def assert_error_raised(self, path, method_name=None):
if method_name is None: self.assertRaises(AssertionError, assert_windows_path, path) else: exc = self.assertRaises(AssertionError, assert_windows_path, path, method_name) self.assertTrue(method_name in exc.message)
* There are lint issues:
== Python Lint Notices ==
./tests/platform/windows/test_os_helper.py: 321: redefinition of function 'test_assert_windows_path_with_illegal_chars' from line 316
« Back to merge proposal
* You're adding a lot of duplication for the tests. What about creating a new assert method and reuse that in every test?
def assert_ error_raised( self, path, method_name=None):
if method_name is None:
self. assertRaises( AssertionError, assert_ windows_ path, path) es(AssertionErr or, assert_ windows_ path, path,
method_ name)
self. assertTrue( method_ name in exc.message)
else:
exc = self.assertRais
* There are lint issues:
== Python Lint Notices ==
./tests/ platform/ windows/ test_os_ helper. py: windows_ path_with_ illegal_ chars' from line 316
321: redefinition of function 'test_assert_