Code review comment for lp:~mandel/ubuntuone-client/add-method-name

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

The ending dots should not be added in _add_method_info but in the strings itself. The code style recommends adding an ending dot to every comment/message/log message, so usually a dev will write that in the same string, and we'll end up with 2 dots (is a bit unexpected to have methods adding ending dots).

review: Needs Fixing

« Back to merge proposal