Code review comment for lp:~mandel/ubuntu-sso-client/windows_ui_3
Revision history for this message
| Alejandro J. Cura (alecu) wrote | # |
review:
Approve
(fixes attached)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Lovely branch!
A few fixes needed, but since they are not blocking, I'm approving anyway:
"Controlled to the ChooseSignIn view/widget." -> EPARSE
"Setting tranlated strings" -> +"s" times two
"Conroller for the setup account view" -> +"t"
"enxt" -> please unwrap
"strengh" -> +"t" times many
"Ui_ChooseSingI
"Represents and enhanced lineedit." -> "an"
"to the cation that will" -> "caption"?
"loginc" -> -"c"
"lwer" -> "lower"
"minimun" -> "minimum"
_strong, _medium, _weak_color -> move the QColors as constants
lines 1680, 1681 in the diff -> remove commented lines