Ubuntu Single Sign On Client

Code review comment for lp:~mandel/ubuntu-sso-client/fix-proxy-q

  1. fix-proxy-q
  2. Merge into trunk
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

I'm getting this:

[FAIL]
Traceback (most recent call last):
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/qt/tests/test_reset_password.py", line 106, in test_show_hide_event
    QtCore.SIGNAL("focusChanged(QWidget*, QWidget*)")), 1)
  File "/usr/lib/python2.7/dist-packages/twisted/trial/unittest.py", line 271, in assertEqual
    % (msg, pformat(first), pformat(second)))
twisted.trial.unittest.FailTest: not equal:
a = 2
b = 1

ubuntu_sso.qt.tests.test_reset_password.ResetPasswordTestCase.test_show_hide_event
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1045, in _inlineCallbacks
    result = g.send(result)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/tests/test_webclient.py", line 570, in test_anonymous_proxy_is_used
    self.wc.force_use_proxy(settings)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 257, in force_use_proxy
    self._set_proxy(proxy)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 111, in _set_proxy
    self.nam.setProxy(proxy)
exceptions.TypeError: QNetworkAccessManager.setProxy(QNetworkProxy): first argument of unbound method must have type 'QNetworkAccessManager'

ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_anonymous_proxy_is_used
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1045, in _inlineCallbacks
    result = g.send(result)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/tests/test_webclient.py", line 618, in test_auth_proxy_is_requested_creds_bad_details
    self.wc.force_use_proxy(wrong_settings)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 257, in force_use_proxy
    self._set_proxy(proxy)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 111, in _set_proxy
    self.nam.setProxy(proxy)
exceptions.TypeError: QNetworkAccessManager.setProxy(QNetworkProxy): first argument of unbound method must have type 'QNetworkAccessManager'

ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_auth_proxy_is_requested_creds_bad_details
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1045, in _inlineCallbacks
    result = g.send(result)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/tests/test_webclient.py", line 666, in test_auth_proxy_is_requested_creds_bad_details_everywhere
    self.wc.force_use_proxy(wrong_settings)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 257, in force_use_proxy
    self._set_proxy(proxy)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 111, in _set_proxy
    self.nam.setProxy(proxy)
exceptions.TypeError: QNetworkAccessManager.setProxy(QNetworkProxy): first argument of unbound method must have type 'QNetworkAccessManager'

ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_auth_proxy_is_requested_creds_bad_details_everywhere
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1045, in _inlineCallbacks
    result = g.send(result)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/tests/test_webclient.py", line 641, in test_auth_proxy_is_requested_creds_bad_details_user
    self.wc.force_use_proxy(partial_settings)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 257, in force_use_proxy
    self._set_proxy(proxy)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 111, in _set_proxy
    self.nam.setProxy(proxy)
exceptions.TypeError: QNetworkAccessManager.setProxy(QNetworkProxy): first argument of unbound method must have type 'QNetworkAccessManager'

ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_auth_proxy_is_requested_creds_bad_details_user
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/tests/test_webclient.py", line 682, in test_auth_proxy_is_requested_user_cancels
    self.wc.force_use_proxy(partial_settings)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 257, in force_use_proxy
    self._set_proxy(proxy)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 111, in _set_proxy
    self.nam.setProxy(proxy)
exceptions.TypeError: QNetworkAccessManager.setProxy(QNetworkProxy): first argument of unbound method must have type 'QNetworkAccessManager'

ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_auth_proxy_is_requested_user_cancels
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1045, in _inlineCallbacks
    result = g.send(result)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/tests/test_webclient.py", line 597, in test_auth_proxy_is_used_creds_requested
    self.wc.force_use_proxy(partial_settings)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 257, in force_use_proxy
    self._set_proxy(proxy)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 111, in _set_proxy
    self.nam.setProxy(proxy)
exceptions.TypeError: QNetworkAccessManager.setProxy(QNetworkProxy): first argument of unbound method must have type 'QNetworkAccessManager'

ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_auth_proxy_is_used_creds_requested
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1045, in _inlineCallbacks
    result = g.send(result)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/tests/test_webclient.py", line 578, in test_authenticated_proxy_is_used
    self.wc.force_use_proxy(settings)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 257, in force_use_proxy
    self._set_proxy(proxy)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 111, in _set_proxy
    self.nam.setProxy(proxy)
exceptions.TypeError: QNetworkAccessManager.setProxy(QNetworkProxy): first argument of unbound method must have type 'QNetworkAccessManager'

ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_authenticated_proxy_is_used
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1045, in _inlineCallbacks
    result = g.send(result)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/tests/test_webclient.py", line 1145, in _assert_ssl_fail_user_accepts
    self.wc.force_use_proxy(proxy_settings)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 257, in force_use_proxy
    self._set_proxy(proxy)
  File "/media/gatox/gato/proyectos/canonical/fix-proxy-q/ubuntu_sso/utils/webclient/qtnetwork.py", line 111, in _set_proxy
    self.nam.setProxy(proxy)
exceptions.TypeError: QNetworkAccessManager.setProxy(QNetworkProxy): first argument of unbound method must have type 'QNetworkAccessManager'

ubuntu_sso.utils.webclient.tests.test_webclient.SSLTestCase.test_ssl_fail_dialog_user_accepts_via_proxy
-------------------------------------------------------------------------------
Ran 755 tests in 87.706s

FAILED (skips=3, failures=1, errors=8, successes=743)

review: Needs Fixing

« Back to merge proposal