Code review comment for lp:~mandel/desktopcouch/add_windows_keyring

Revision history for this message
Chad Miller (cmiller) wrote :

38 + def __init__(self, make_random_string_fn=make_random_string,
39 + registry=None, crypto=None):
40 +

If you inherit from object, you much call object's __init__().
> super(Keyring, self).__init__()

73 + for index in count():

Very sexy. Thx.

review: Needs Fixing

« Back to merge proposal