Code review comment for lp:~mandel/dbus-cpp/expose_executor

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

So, I found the reason for the symbols failure. It seems that dpkg-gensymbols (and related) is just stupid. The problem is in this line of debian/libdbus-cpp3.symbols.32bit:

+ (c++)"core::dbus::asio::make_executor(std::shared_ptr<core::dbus::Bus> const&, boost::asio::io_service &)@Base" 0replaceme

It should be:

+ (c++)"core::dbus::asio::make_executor(std::shared_ptr<core::dbus::Bus> const&, boost::asio::io_service&)@Base" 0replaceme

Please notice that there *cannot* be a whitespace between the typename and the pointer/reference sign. This actually causes a SYMBOL MISMATCH. So, dpkg-gensymbols is not whitespace-tolerant...

review: Needs Fixing

« Back to merge proposal