Merge lp:~malizor/activity-log-manager/fix-967150 into lp:~activity-log-manager/activity-log-manager/vala

Proposed by Nicolas Delvaux
Status: Merged
Merged at revision: 126
Proposed branch: lp:~malizor/activity-log-manager/fix-967150
Merge into: lp:~activity-log-manager/activity-log-manager/vala
Diff against target: 11 lines (+1/-1)
1 file modified
src/history-widget.vala (+1/-1)
To merge this branch: bzr merge lp:~malizor/activity-log-manager/fix-967150
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email:

Description of the change

The "Forget activities" string was separated from its colon.
Because of a Rosetta bug, this led to bad translations (eg. in French, impossible to add a space between the string and the colon).

This patch has zero regression potential, but it creates a new string.
So this means translations have to be updated accordingly, which is the point of the related bug anyway (to be able to translate this string properly).

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Looking good, Thanks Nicolas :)

Better to merge now so that on next release, people will have time to translate it.

review: Approve
Revision history for this message
Nicolas Delvaux (malizor) wrote :

This fix was merged more than 6 months ago and and it has yet to reach any Ubuntu version.
I understand doing a release only for such a small fix is not really exciting, but what is the point of writing patches if they may never reach users?

So, if no more work is planned on Activity Log Manager for Saucy, could someone just release a new package?


Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

I will have a look at this patch and make sure it makes it on 0.9.7 release in maybe a week. Thanks for bringing it to my notice.

At the moment the focus of development is a different branch, but I will apply this patch to the focus of development branch

Revision history for this message
Nicolas Delvaux (malizor) wrote :

Thanks Manish, let me know if I need to submit a new merge request against any other branch.

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

It's fine. I can just merge it directly if ubuntu focus of development branch does not have this patch applied

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/history-widget.vala'
2--- src/history-widget.vala 2012-03-18 09:11:52 +0000
3+++ src/history-widget.vala 2012-09-20 17:37:35 +0000
4@@ -58,7 +58,7 @@
6 var text_box = new Box(orientation=Orientation.VERTICAL, 0);
7 var header = new Label("");
8- header.set_markup("<b>%s:</b>".printf(_("Forget activities")));
9+ header.set_markup("<b>%s</b>".printf(_("Forget activities:")));
10 header.set_alignment(0, (float)0.5);
11 header.set_padding(0, 0);


People subscribed via source and target branches