Merge lp:~malizor/activity-log-manager/fix-967150 into lp:~activity-log-manager/activity-log-manager/vala

[Nicolas Delvaux]

The "Forget activities" string was separated from its colon.
Because of a Rosetta bug, this led to bad translations (eg. in French, impossible to add a space between the string and the colon).

This patch has zero regression potential, but it creates a new string.
So this means translations have to be updated accordingly, which is the point of the related bug anyway (to be able to translate this string properly).

[Didier Roche (didrocks)]

Looking good, Thanks Nicolas :)

Better to merge now so that on next release, people will have time to translate it.

review: Approve

[Nicolas Delvaux (malizor)]

This fix was merged more than 6 months ago and and it has yet to reach any Ubuntu version.
I understand doing a release only for such a small fix is not really exciting, but what is the point of writing patches if they may never reach users?

So, if no more work is planned on Activity Log Manager for Saucy, could someone just release a new package?

Thanks!

[Manish Sinha (मनीष सिन्हा) (manishsinha)]

I will have a look at this patch and make sure it makes it on 0.9.7 release in maybe a week. Thanks for bringing it to my notice.

At the moment the focus of development is a different branch, but I will apply this patch to the focus of development branch

[Nicolas Delvaux (malizor)]

Thanks Manish, let me know if I need to submit a new merge request against any other branch.

[Manish Sinha (मनीष सिन्हा) (manishsinha)]

It's fine. I can just merge it directly if ubuntu focus of development branch does not have this patch applied

=== modified file 'src/history-widget.vala'
--- src/history-widget.vala	2012-03-18 09:11:52 +0000
+++ src/history-widget.vala	2012-09-20 17:37:35 +0000
@@ -58,7 +58,7 @@
 
 			var text_box = new Box(orientation=Orientation.VERTICAL, 0);
 			var header = new Label("");
-			header.set_markup("<b>%s:</b>".printf(_("Forget activities")));
+			header.set_markup("<b>%s</b>".printf(_("Forget activities:")));
 			header.set_alignment(0, (float)0.5);
 			header.set_padding(0, 0);