Code review comment for lp:~malept/pyexiv2/0.2-ReadMetadataTestCase

Revision history for this message
Mark Lee (malept) wrote :

> > > I have one remark on the consistency of the checks: the original case
> tests
> > > the python type of the values of EXIF and IPTC tags. In the case you
> added,
> > > the check is on the tag's type, not the type of the corresponding python
> > > object.
> >
> > So you want to check tag.type (e.g., 'Ascii' for some strings)? I presume
> that
> > you don't want to check tag.__class__ anymore, because that seems to always
> be
> > ExifTag.
>
> No, for the sake of consistency, I would rather check tag.value.__class__, as
> is done for EXIF and IPTC tags.

OK, I think I confused myself. I'll change the XMP tests to use Python types instead of ``tag.type``s.

« Back to merge proposal