Code review comment for lp:~makyo/juju-quickstart/ssh-3-watch-keys

Revision history for this message
Richard Harding (rharding) wrote :

QA:

The text is too long and should wrap. I had the text wrapping mid-word
because of the length. I think a standard 78ish for terminal work would
be really nice.

http://uploads.mitechie.com/lp/quickstart.png

A list of options would read cleaner.

"Quickstart can

[a] Automatically create keys
[s] Provide you commands to create keys yourself
[C] Cancel Quickstart
"

There was a big lack of warning that it was going on into bootstrap and
such after the key creation. Maybe a pause/continue makes sense there?

Trying manual instructions:

What's the .? Is it doing something? I thought it was waiting for me to
enter a command?

Again, the instructions but up. It's not clear what's part of this step
and the last bit of info.

Once I did enter the command, the ...... wasn't cleared before the
'bootstraping' log line so I got.

........................bootstrapping the azure environment (type:
azure)

Trying to cancel:

I get a traceback during a ctrl-c to kill. It should be caught/exit
cleanly.

If I start to automatically create, but cancel when it asks me for a
passphrase it also dumps a traceback at me.

I'd propose something that looks to the user more like:

http://paste.ubuntu.com/6595673/

Note the use of more usual opposites of automatic/manual, indentation to
help distinguish commands to run manually as a callout, etc.

https://codereview.appspot.com/39610049/

« Back to merge proposal