Code review comment for lp:~makyo/juju-quickstart/ssh-3-watch-keys

Revision history for this message
Gary Poster (gary) wrote :

Cool.

I could very well be wrong, but I think that the script should start the agent and add the key. Any thing else seems like it could easily go wrong and hang forever.

That's what I was trying to get to work, briefly. It's what the other code path needs, and it seems like it is not working yet either.

Gary

> On Dec 13, 2013, at 6:31 PM, <email address hidden> wrote:
>
> Putting this branch on hold, then. Thanks for the QA, Gary. We need to
> find a check_ssh_keys method that actually checks if keys are available
> to the agent, which will be the case once the user enters the password
> (no matter how it works: automatic creation or manual). I'll add the
> docstrings and push, then start researching tonight/this weekend on SSH
> solutions.
>
> Thanks again
>
> https://codereview.appspot.com/39610049/

« Back to merge proposal