Code review comment for lp:~makyo/juju-quickstart/ssh-3-watch-keys

Other than needing to add some docstrings, this looks good, but the QA
is still bad.

Note I am using a passphrase when I QA.

I was able to get it to work when I did the following.

(1) In the other terminal, also *add* the new key

ssh-keygen -b 4096 -t rsa && ssh-agent && ssh-add

(2) In the code, I did a time.sleep(10) after it saw the key in order to
wait for me to type the password in. This is obviously not ideal.

Note that I am pretty sure that create_ssh_keys should run ssh-add also.

Ideally, I think the script would run ssh-agent and ssh-add. In quick
hacks, I couldn't get this to work. I started debugging and it might be
that it needed some time in between the call to ssh-agent and ssh-add.
I'm not sure. Note that ssh-add needs to be interactive, so utils.call
can't work as is. We need stdin and stdout to be used.

Sorry it is still not working for me.

https://codereview.appspot.com/39610049/diff/20001/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/39610049/diff/20001/quickstart/app.py#newcode119
quickstart/app.py:119: def check_ssh_keys():
docstring please

https://codereview.appspot.com/39610049/diff/20001/quickstart/app.py#newcode124
quickstart/app.py:124: def watch_for_ssh_keys():
docstring please

https://codereview.appspot.com/39610049/