Code review comment for lp:~makyo/juju-quickstart/ssh-3-watch-keys

Revision history for this message
Gary Poster (gary) wrote :

Wording suggestions. Didn't look other than that for now.

https://codereview.appspot.com/39610049/diff/1/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/39610049/diff/1/quickstart/app.py#newcode99
quickstart/app.py:99: 'Would you like quickstart to create them for you?
Note that '
What do you think of something like this? Please feel free to polish or
counter-propose.

----

No SSH keys were found in ~/.ssh

To proceed, quickstart can automatically create keys for you [a], or it
can give you a command to run yourself [s] in another terminal or window
to create the keys.

Note that, if you want quickstart to create your key, the underlying
program (ssh-keygen) will ask for a passphrase, but quickstart will not
have access to it.

Automatically create keys [a], create the keys yourself [s], or cancel
[C]?

https://codereview.appspot.com/39610049/diff/1/quickstart/app.py#newcode112
quickstart/app.py:112: raise ProgramExit('Please run this command and
follow the '
If you would like to create the keys yourself, please run this command
and then re-run quickstart:

ssh-keygen -b 4096 -t rsa

https://codereview.appspot.com/39610049/diff/1/quickstart/app.py#newcode120
quickstart/app.py:120: return utils.call('/usr/bin/find', ssh_dir,
'-name', 'id_*.pub')[0]
We can wait for Windows compatibility, but it would be nice if
quickstart used built in Python tools rather than find. <shrug> for
now.

https://codereview.appspot.com/39610049/

« Back to merge proposal