Code review comment for lp:~makyo/juju-gui/recess

Thanks for the reviews.

https://codereview.appspot.com/7067057/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/7067057/diff/1/Makefile#newcode227
Makefile:227: recess lib/views/stylesheet.less --config recess.json |
grep -q Perfect
On 2013/01/09 22:10:24, gary.poster wrote:
> This runs a global "recess" and not the one installed locally.
> http://pastebin.ubuntu.com/1514675/ has a fix for this.

Good catch! Had it installed globally for testing and had forgotten.
Applied the patch.

https://codereview.appspot.com/7067057/diff/1/lib/templates.js
File lib/templates.js (right):

https://codereview.appspot.com/7067057/diff/1/lib/templates.js#newcode191
lib/templates.js:191: });
On 2013/01/09 22:10:24, gary.poster wrote:
> I wonder about this change, but I am OK with it. Simply using less
and relying
> on recess for later linting might be nicer. OTOH, maybe this keeps us
from
> falling over when the LESS file is bad.

I reverted this change. recess just uses less to compile, and if the
LESS file is bad, the error we get is the error from the less package.
No real value added.

https://codereview.appspot.com/7067057/