juju-gui

Merge lp:~makyo/juju-gui/make-clean-1090086 into lp:juju-gui/experimental

  1. make-clean-1090086
  2. Merge into trunk
Proposed by Madison Scott-Clary
Status: Merged
Merged at revision: 283
Proposed branch: lp:~makyo/juju-gui/make-clean-1090086
Merge into: lp:juju-gui/experimental
Diff against target: 11 lines (+1/-0)
1 file modified
Makefile (+1/-0)
To merge this branch: bzr merge lp:~makyo/juju-gui/make-clean-1090086
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+139967@code.launchpad.net

Description of the change

make clean to remove links

The clean target now removes symlinks in app/assets/javascripts.

https://codereview.appspot.com/6945057/

To post a comment you must log in.
Revision history for this message
Madison Scott-Clary (makyo) wrote :

Reviewers: mp+139967_code.launchpad.net,

Message:
Please take a look.

Description:
make clean to remove links

The clean target now removes symlinks in app/assets/javascripts.

https://code.launchpad.net/~makyo/juju-gui/make-clean-1090086/+merge/139967

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6945057/

Affected files:
   M Makefile
   A [revision details]

Index: Makefile
=== modified file 'Makefile'
--- Makefile 2012-12-13 18:42:03 +0000
+++ Makefile 2012-12-14 17:01:19 +0000
@@ -343,6 +343,7 @@

  clean:
   rm -rf build build-debug build-prod
+ find app/assets/javascripts/ -type l | xargs rm -rf

  clean-deps:
   rm -rf node_modules virtualenv

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Revision history for this message
Gary Poster (gary) wrote :

Looks good, thank you. :-)

Gary

https://codereview.appspot.com/6945057/

Revision history for this message
Gary Poster (gary) wrote :

On 2012/12/14 17:21:34, gary.poster wrote:
> Looks good, thank you. :-)

> Gary

Um, I meant "Land as is." :-)

https://codereview.appspot.com/6945057/

Revision history for this message
Brad Crittenden (bac) wrote :

It looks good Matt and is landable as is.

I asked on IRC if you'd consider adding the following to avoid us having
another branch:
http://paste.ubuntu.com/1439028/

Totally your call.

https://codereview.appspot.com/6945057/

Revision history for this message
Madison Scott-Clary (makyo) wrote :

*** Submitted:

make clean to remove links

The clean target now removes symlinks in app/assets/javascripts.

R=gary.poster, bac
CC=
https://codereview.appspot.com/6945057

https://codereview.appspot.com/6945057/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2012-12-13 18:42:03 +0000
3+++ Makefile 2012-12-14 17:05:29 +0000
4@@ -343,6 +343,7 @@
5
6 clean:
7 rm -rf build build-debug build-prod
8+ find app/assets/javascripts/ -type l | xargs rm -rf
9
10 clean-deps:
11 rm -rf node_modules virtualenv

Subscribers

People subscribed via source and target branches